chore: Override sentry DSN with env var #2388
Closed
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
murarustefaan
left a comment
murarustefaan
left a comment
There was a problem hiding this comment.
I don't think allowing an overwrite of an internal plugin DSN is a good decision. Why would someone want to do this?
Member
Author
|
We may want to do it once we refresh some DSNs, etc. |
Member
But that should be done in the plugins directly, otherwise there would be 2 sources of truth for the DSNs (one, in the plugin, which should IMO be the main and only one and 2, in a database configuration for usage as an ENV variable). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2386
This way once we update a plugin to use the updated SDK, it's easier to override the DSN if needed - without having to release anything.