Merged
Conversation
This incidentally fixes linter issues with GitHub actions. Not sure what the cause is, but upgrading fixes it and there is no reason not to.
mweibel
reviewed
Dec 18, 2025
Collaborator
mweibel
left a comment
mweibel
left a comment
There was a problem hiding this comment.
Generally agree with upgrading to Go 1.25.
I think the integration test failed overnight because Kubernetes 1.35 got released yesterday.
The question we need to ask however, is what Kubernetes versions we support. The README states the last 3 releases, meaning in this case: 1.35, 1.34, 1.33.
IIRC (correct me if I'm wrong): we should therefore require Kubernetes dependencies with versions 0.33.x to make sure we don't fail on older versions.
I believe this is also what we do in our CSI driver although there we need to update the deps pretty soon.. 😄
Contributor
Author
|
As discussed, we might change the situation with our dependencies. but go ahead and merge the change to fix our tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This incidentally fixes linter issues with GitHub actions. Not sure what the cause is, but upgrading fixes it and there is no reason not to.