Skip to content

#482 add missing checks to js sanitiser #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JimKerslake merged 1 commit into from
Aug 20, 2025
Merged

#482 add missing checks to js sanitiser #656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions src/cloudscribe.SimpleContent.Web/Services/Page/JsSecuritySanitizer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ public class JsSecuritySanitizer
"location.href", // Commonly set to redirect
"document.location", // Same
"window.name", // Used to pass data between domains
"localStorage", // Persistent local storage
"sessionStorage", // Session-scoped storage
"localStorage", // Persistent local storage (including .setItem, .getItem, etc.)
"sessionStorage", // Session-scoped storage (including .setItem, .getItem, etc.)
"indexedDB", // DB access
"navigator.geolocation", // Gets user location
"navigator.clipboard", // Read/write clipboard
Expand Down Expand Up @@ -108,6 +108,27 @@ private void TraverseNode(Node node, List<string> issues)
{
issues.Add($"Call to disallowed function: {ident.Name}");
}

// Check for method calls on dangerous objects (e.g., localStorage.setItem)
if (callExpr.Callee is MemberExpression memberCall &&
memberCall.Object is Identifier objIdent)
{
// Check if it's a dangerous object being called
if (DangerousProperties.Contains(objIdent.Name))
{
issues.Add($"Method call on disallowed object: {objIdent.Name}");
}
}
}

// Check for dangerous constructor calls (new XMLHttpRequest(), new Function(), etc.)
if (node is NewExpression newExpr)
{
if (newExpr.Callee is Identifier ident &&
DangerousCalls.Contains(ident.Name))
{
issues.Add($"Use of disallowed constructor: new {ident.Name}()");
}
}

// Check for dangerous property access like window.location or document.cookie
Expand Down