Skip to content

fix: support new swagger-codegen format for cloudsmith-api#74

Merged
paddycarey merged 1 commit intomasterfrom
noticket/support-new-swagger-codegen-format-for-api
Mar 3, 2022
Merged

fix: support new swagger-codegen format for cloudsmith-api#74
paddycarey merged 1 commit intomasterfrom
noticket/support-new-swagger-codegen-format-for-api

Conversation

@paddycarey
Copy link
Member

This PR adjusts the CLI to support swagger-codegen's newer Configuration() style (without the global singleton).

Upstream change was made here swagger-api/swagger-codegen#9130

This change is required due to an upgrade in the swagger-codegen version we use to generate our API client libs over in cloudsmith-io/cloudsmith-api#27

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 256e821 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 0.9% (0.0% change).

View more on Code Climate.

@DavidS-cloud
Copy link
Contributor

Should this also update https://github.com/cloudsmith-io/cloudsmith-cli/blob/master/setup.py#L55 to exclude incompatible API versions?

@paddycarey
Copy link
Member Author

Should this also update https://github.com/cloudsmith-io/cloudsmith-cli/blob/master/setup.py#L55 to exclude incompatible API versions?

The CLI remains compatible with both old and new versions of the API bindings after this change, so no need to update here.

@paddycarey paddycarey merged commit 6926201 into master Mar 3, 2022
@paddycarey paddycarey deleted the noticket/support-new-swagger-codegen-format-for-api branch March 3, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants