fix: support new swagger-codegen format for cloudsmith-api#74
Merged
paddycarey merged 1 commit intomasterfrom Mar 3, 2022
Merged
Conversation
|
Code Climate has analyzed commit 256e821 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 0.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 0.9% (0.0% change). View more on Code Climate. |
Contributor
|
Should this also update https://github.com/cloudsmith-io/cloudsmith-cli/blob/master/setup.py#L55 to exclude incompatible API versions? |
Member
Author
The CLI remains compatible with both old and new versions of the API bindings after this change, so no need to update here. |
DavidS-cloud
approved these changes
Mar 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the CLI to support
swagger-codegen's newerConfiguration()style (without the global singleton).Upstream change was made here swagger-api/swagger-codegen#9130
This change is required due to an upgrade in the
swagger-codegenversion we use to generate our API client libs over in cloudsmith-io/cloudsmith-api#27