Remove shared state (AddressingProperties) taking WinRmClient closer to thread safety#65
Merged
Remove shared state (AddressingProperties) taking WinRmClient closer to thread safety#65
Conversation
…to thread safety AddressingProperties was shared between all requests, making it impossible to use the same WinRmClient concurrently. It stores things like the current action name (which we had to update because it takes the first one otherwise), the message id. We needed that so we can force CXF into using the 2004 version of the addressing namespace. The changes here take a different approach (creating a policy and setting a special assertion on it), causing CXF to create the AddressingProperties object per request.
Contributor
Author
|
That's been a long awaited cleanup. Tests are passing - any breakage will be quite obvious (the action not matching). Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AddressingProperties was shared between all requests, making it impossible to use the same WinRmClient concurrently. It stores things like the current action name (which we had to update because it takes the first one otherwise), the message id. We needed that so we can force CXF into using the 2004 version of the addressing namespace. The changes here take a different approach (creating a policy and setting a special assertion on it), causing CXF to create the AddressingProperties object per request.