This repository was archived by the owner on Mar 16, 2022. It is now read-only.
Avoid dead letter logs on event-sourced entity passivation#390
Merged
Conversation
ralphlaude
added a commit
to ralphlaude/cloudstate
that referenced
this pull request
Jul 12, 2020
pvlugter
force-pushed
the
passivation-dead-letter
branch
3 times, most recently
from
31e1888 to
855192a
Compare
pvlugter
force-pushed
the
passivation-dead-letter
branch
from
855192a to
1020fc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #389.
When the entity passivates, it sends a Success message to the relay actor for the stream to shut down, it also stops the entity actor. The entity supervisor stops when it sees that the entity manager actor has terminated. But the stream also has an actorRef sink pointing to the supervisor, which sees the supervisor terminate (before the stream has completed) and so fails the stage, sending a Failure message to the already terminated supervisor.
First commit avoids the dead letter log by using a
StreamFailedmessage withDeadLetterSuppression, like theStreamClosedmessage.But since we may actually want the stream to drain and complete cleanly, second commit updates the entity stop to be more graceful around stream termination.
We'll still want some tests for entity passivation. Tracked in #359.