This repository was archived by the owner on Mar 16, 2022. It is now read-only.
Fix empty streamed responses (for CRDT entities)#494
Merged
Conversation
2 tasks
Contributor
Thanks @pvlugter. I'll add them with cloudstateio/go-support#56 when this PR is merged I think. |
Closed
jroper
approved these changes
Dec 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #493. Fix for this was simple: don't filter out empty client actions in
UserFunctionRouter. We need a first empty response to always be sent downstream, otherwise an HttpResponse is never created due to waiting for the first response to extract metadata. Empty client actions will be filtered out inCommandHandler.processRepliesinstead.Added tests to the TCK for this, including a proxy intercept test that has same behaviour as the presence example but using the CRDT TCK model entity.
@marcellanz, some updates to the CRDT TCK to include for Go support.