This repository was archived by the owner on Mar 16, 2022. It is now read-only.
Fix proto descriptor extract service#497
Closed
pvlugter wants to merge 1 commit into
Closed
Conversation
Member
|
I think I fixed this in #465. |
Member
Author
👍 Ah, didn't think of checking that PR. Yes, fixed in the same way with a |
Member
Author
|
I'm assuming #465 ends up testing this in some way then, if it was uncovered then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #496.
If there are multiple entities registered, which have separate file descriptors but share the same package name, then subsequent services can't be found. The
extractServicemethod is used to collect the first matching service. Previously it would filter on the package, and then do afindServiceByName, but this will return aSome(null)on an earlier file descriptor if the service is actually in a later file descriptor. Update to only returnSome(serviceDescriptor)if found, otherwiseNoneto continue the search. I'm assuming this was the original intention.Can follow up with a test...