Add s3 datasources for bootstrap bucket. Add testing patterns.#2
Merged
Add s3 datasources for bootstrap bucket. Add testing patterns.#2
Conversation
jwitko
force-pushed
the
feature/datasources-and-tests
branch
from
29bac72 to
c98ea3e
Compare
jwitko
changed the title
…test objects, add testing patterns
jwitko
force-pushed
the
feature/datasources-and-tests
branch
from
c98ea3e to
9a66dc2
Compare
wolf31o2
requested changes
Mar 23, 2022
| # Generate SSH keypair | ||
| resource "tls_private_key" "generated_ssh_key_pair" { | ||
| count = local.create_new_ssh_key ? 1 : 0 | ||
| count = local.create_new_ssh_key ? 1 : 0 |
Contributor
There was a problem hiding this comment.
This generates a new key, and doesn't use var.ssh_public_key, yet it's count is based on length of var.ssh_public_key being > 0... I'm confused on exactly what the intent is here.
Contributor
Author
There was a problem hiding this comment.
That looks wrong. Should be == 0. Adding a new commit to fix and add comments to make it more clear.
wolf31o2
approved these changes
Apr 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.