Fix trigger_test_sqlserver test case failure#12
Conversation
- use SET NOCOUNT ON so that the number of rows affected by INSERT statement is returned instead of the number of rows affected by the trigger - Refer https://techcommunity.microsoft.com/t5/SQL-Server/UPDATE-with-OUTPUT-clause-8211-Triggers-8211-and-SQLMoreResults/ba-p/383457
|
I wish the title of this commit message was more detailed. While the change being made here will fix the test, that's not the core/direct change being made. Something like: SET NOCOUNT ON for all insert statements I also wonder if this will cause compatibility errors for older version of SQL Server? |
We will make sure to test AVM on rails 5.1 in all the supported versions of SQLServer. It is included as one of the test strategy for rails 5.1 https://confluence.eng.vmware.com/display/RT/Rails+Upgrade+5.0.7.1+to+5.1.6.1 |
statement is returned instead of the number of rows affected by the trigger
https://confluence.eng.vmware.com/display/RT/Rails+Upgrade+4.2+to+5.0+with+ActiveRecord+SQLServer+Adapter+supporting+ODBC