Merged
Conversation
They lead to output instabilities. We *should* fix the instabilities instead, but for now let's ignore the case.
AsterDY
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
现有代码仍然不稳定 (issue #33 ),同样输入输出不同………………
一个问题是 (issue #44 ) 里的重名函数,这个一直我们都没说怎么修(没定义正确行为),所以直接先不考虑了。
另一个还是遍历没写对,导致不同顺序带来不同结果的问题
PR desc
现有的代码逻辑如下
考虑 a 和其依赖 dep,并且 dep 是外部符号所以会被 loadExternal 筛出去
如果访问顺序是 a, dep,那么会
如果反过来,是
这样,前者会导致 dep 不会出现在最终的 FunctionCall 里,但后者会出现。