Skip to content

feat: add helper functions for AgenticMessage#582

Merged
mrh997 merged 1 commit intorelease/agentic_modelfrom
feat/mrh/agentic_model
Dec 1, 2025
Merged

feat: add helper functions for AgenticMessage#582
mrh997 merged 1 commit intorelease/agentic_modelfrom
feat/mrh/agentic_model

Conversation

@mrh997
Copy link
Copy Markdown
Contributor

@mrh997 mrh997 commented Nov 27, 2025

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@mrh997 mrh997 force-pushed the feat/mrh/agentic_model branch from d623f0f to b181caa Compare November 27, 2025 08:13
@mrh997 mrh997 force-pushed the feat/mrh/agentic_model branch 3 times, most recently from d3f6791 to 705574f Compare November 28, 2025 06:43
@mrh997 mrh997 force-pushed the feat/mrh/agentic_model branch from 705574f to c3e4260 Compare November 28, 2025 07:28
@mrh997 mrh997 force-pushed the feat/mrh/agentic_model branch from c3e4260 to c05d933 Compare November 28, 2025 07:53
type UserInputAudio struct {
URL *string
Base64Data *string
URL string
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么去掉了指针

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前message定的时候没设计好,改成非指针有几个考量点

  1. 易用性;
  2. 指针没能发挥出 oneof 的语义,Base64Data 时 MIMEType 必填,URL 时则不需要填 MIMEType。用注释表达会更好一些

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gemini url 时 mime type 也是必填

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这就是问题了。。各厂商定义不一样,用指针没啥好处

@mrh997 mrh997 force-pushed the feat/mrh/agentic_model branch from c05d933 to 9ed382a Compare November 28, 2025 09:32
@mrh997 mrh997 force-pushed the feat/mrh/agentic_model branch from 9ed382a to 52e2d9e Compare November 28, 2025 10:00
@mrh997 mrh997 force-pushed the feat/mrh/agentic_model branch from 52e2d9e to 15d20cd Compare November 30, 2025 14:22
@mrh997 mrh997 merged commit 890074d into release/agentic_model Dec 1, 2025
9 of 10 checks passed
@mrh997 mrh997 deleted the feat/mrh/agentic_model branch December 1, 2025 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants