Skip to content

Conversation

@stevelw
Copy link
Collaborator

@stevelw stevelw commented Nov 25, 2024

No description provided.

@stevelw
Copy link
Collaborator Author

stevelw commented Nov 25, 2024

Relates to clowder-cloud/mock_device#1

@stevelw stevelw requested a review from jeepies November 25, 2024 21:43
@jeepies
Copy link
Member

jeepies commented Nov 25, 2024

I'd be happy to sign this off if you acknowledge that this just makes all these fields useless in the testData for mock-device. Are you assuming we will implement these later down the line?

Also, sorry if that sounded crabby - I wasn't too sure how to word it

@stevelw
Copy link
Collaborator Author

stevelw commented Nov 25, 2024

  1. They're never useless because they're based on 'real' data. Even if we're not using the data we should make sure, for example, it doesn't crash the server.
  2. We will probably add things like battery, and possibly accuracy (if it's too inaccurate, should they get points?) but as Rose always says we shouldn't preempt things when writing code and only add them when needed.

If you did want to keep it, then the fix would be to change the type to string (we don't know yet from the developer what the type is, so it could be either - and it's easier to change this than the test data)

@jeepies jeepies merged commit a0e1c36 into main Nov 25, 2024
3 checks passed
@jeepies jeepies deleted the CL-107-fix-backend-expecting-different-data-format branch November 25, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants