Release/1.15.1 #191
Merged
Release/1.15.1 #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in `EventSinkService` when a user was not logged in. Replaced `get()` with `getOrElse()`.
# Conflicts: # CHANGELOG.md # app/services/EventSinkService.scala
…xchange. Let clients do that so that we don't have a queue for the eventsink filling up if there are no consumers.
robkooper
reviewed
Mar 11, 2021
max-zilla
approved these changes
Mar 11, 2021
Contributor
max-zilla
left a comment
max-zilla
left a comment
There was a problem hiding this comment.
Ran and verified new category field for events, didn't encounter issues. Didn't catch anything in code.
bodom0015
requested changes
Mar 11, 2021
bodom0015
reviewed
Mar 11, 2021
Co-authored-by: Mike Lambert <lambert8@illinois.edu>
Co-authored-by: Mike Lambert <lambert8@illinois.edu>
bodom0015
approved these changes
Mar 15, 2021
Member
bodom0015
left a comment
bodom0015
left a comment
There was a problem hiding this comment.
LGTM, aside from the issue noted below. If we're moving RabbitMQ to a hard requirement then please disregard, but I don't recall that being part of the discussion of these feature.
Co-authored-by: Mike Lambert <lambert8@illinois.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.15.1 - 2021-03-12
Fixed
EventSinkServicewhen a user was not logged in.Replaced
get()withgetOrElse().EventSinkServicelogging to debug to minimize chatter.have a queue for the eventsink filling up if there are no consumers.