-
Notifications
You must be signed in to change notification settings - Fork 19
Support private extractor registration #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
robkooper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, need to do testing
| } | ||
| val upper_categories = categories.map(cat => cat.toUpperCase) | ||
| val category_match = categories.length == 0 || doc.categories.intersect(upper_categories).length > 0 | ||
| val category_match = doc.categories.length == 0 || doc.categories.intersect(upper_categories).length > 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this a bug?
ddey2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it.Looks good to me
lmarini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Max is adding checks to api.Extractions.submitFileToExtractor and api.Extractions.submitDatasetToExtractor
|
not sure why the checks are not running, but on my local machine I get compile errors: |
Adds support for a unique_key and owner parameter to register extractors for personal use. Links to come for related pyclowder and extractor code.