Skip to content

Conversation

@cconsta1
Copy link
Contributor

Description

I implemented an IFC previewer and added GLTF loading capabilities to the three_js previewer

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the CHANGELOG.md.
  • I have signed the CLA
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Mar 26, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ cconsta1
✅ lmarini
❌ Chrysovalantis Constantinou


Chrysovalantis Constantinou seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cconsta1
Copy link
Contributor Author

I found an IFC file for testing here and GLTF files can be found here.

@lmarini
Copy link
Member

lmarini commented Mar 28, 2022

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.✅ cconsta1❌ Chrysovalantis Constantinou
Chrysovalantis Constantinou seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cconsta1 it looks like the commit from 4 days ago was done using a different username. Can you approve the CLA using that username as well? Thanks!

@cconsta1
Copy link
Contributor Author

Hi @lmarini,

I got a new machine and when I made the first commit, my local git on my machine was not linked to my email account yet. I did that after I made my first commit, that's why the only thing that appears in the first commit is my name (Chrysovalantis Constantinou), whereas with the second and third commits my regular username cconsta1 appears. Is there a way around this? Or shall I close this pr and open a new one?

@lmarini
Copy link
Member

lmarini commented Mar 28, 2022

Hi @lmarini,

I got a new machine and when I made the first commit, my local git on my machine was not linked to my email account yet. I did that after I made my first commit, that's why the only thing that appears in the first commit is my name (Chrysovalantis Constantinou), whereas with the second and third commits my regular username cconsta1 appears. Is there a way around this? Or shall I close this pr and open a new one?

That's fine. Thanks for the clarification. Since there isn't another email/account specified, I think we good.

@cconsta1
Copy link
Contributor Author

@lmarini, that's cool then! I also changed the mimetypes by adding model/ifc, model/IFC. I hope things work and thanks!

@lmarini lmarini self-requested a review June 14, 2022 17:25
Copy link
Member

@lmarini lmarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both worked well. Thank you!

@lmarini lmarini merged commit 5dbbbef into clowder-framework:develop Jun 14, 2022
@cconsta1
Copy link
Contributor Author

Awesome! Thanks @lmarini!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants