-
Notifications
You must be signed in to change notification settings - Fork 19
Added an IFC previewer and a GLTF previewer #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Chrysovalantis Constantinou seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
@cconsta1 it looks like the commit from 4 days ago was done using a different username. Can you approve the CLA using that username as well? Thanks! |
|
Hi @lmarini, I got a new machine and when I made the first commit, my local |
That's fine. Thanks for the clarification. Since there isn't another email/account specified, I think we good. |
|
@lmarini, that's cool then! I also changed the mimetypes by adding |
lmarini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both worked well. Thank you!
|
Awesome! Thanks @lmarini! |
Description
I implemented an IFC previewer and added GLTF loading capabilities to the
three_jspreviewerReview Time Estimate
Types of changes
Checklist: