Skip to content

Added logic for primary Clowder instance which handles multiple extra… #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
robkooper merged 3 commits into from
May 3, 2022
Merged

Added logic for primary Clowder instance which handles multiple extra… #348

robkooper merged 3 commits into from
May 3, 2022

Conversation

@ddey2
Copy link
Member

@ddey2 ddey2 commented Apr 7, 2022 •
edited
Loading

…ctors problem and multiple indexing issue

Description

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the CHANGELOG.md.
  • I have signed the CLA
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ddey2 ddey2 requested review from lmarini, max-zilla and robkooper April 7, 2022 20:43
@robkooper robkooper linked an issue Apr 11, 2022 that may be closed by this pull request
same extractor shows up multiple times #327
Closed
robkooper
robkooper requested changes Apr 11, 2022
View reviewed changes
conf/application.conf Outdated
# All requests to extractors and any other external process is send
# using rabbitmq, this will setup the connection information.
clowder.rabbitmq.uri="amqp://guest:guest@localhost:5672/%2f"
clowder.primary=true
Copy link
Member

@robkooper robkooper Apr 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is in the middle of the rabbitmq section, probably better to put it in its own area and add some text what this does (mention that it is only needed in case you use multiple instances of clowder).

Copy link
Member Author

@ddey2 ddey2 Apr 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took care of this.

@ddey2 ddey2 requested a review from robkooper April 12, 2022 13:54
@robkooper robkooper changed the base branch from develop to release/1.20.2 April 29, 2022 15:58
@robkooper robkooper added this to the 1.20.2 milestone Apr 29, 2022
@robkooper robkooper merged commit 359df51 into release/1.20.2 May 3, 2022
@robkooper robkooper deleted the ddey2/327 branch May 3, 2022 20:58
@robkooper robkooper mentioned this pull request Jul 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robkooper robkooper robkooper approved these changes

@max-zilla max-zilla max-zilla approved these changes

@lmarini lmarini Awaiting requested review from lmarini

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.20.2

Development

Successfully merging this pull request may close these issues.

same extractor shows up multiple times

4 participants

@ddey2 @robkooper @max-zilla