Skip to content

Conversation

@robkooper
Copy link
Member

Description

When the filename had a ' in the name it would download as blob. Cleaned up the code and tested with Edge/Chrome/Safari/Firefox

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the CHANGELOG.md.
  • I have signed the CLA
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@robkooper robkooper changed the base branch from develop to release/1.20.2 April 29, 2022 15:57
@robkooper robkooper added this to the 1.20.2 milestone Apr 29, 2022
@robkooper robkooper merged commit 8ba7532 into release/1.20.2 May 3, 2022
@robkooper robkooper deleted the fix-download-name branch May 3, 2022 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants