Skip to content

Conversation

@robkooper
Copy link
Member

@robkooper robkooper commented Jul 28, 2022

Description

if secrets.DOCKERHUB_USERNAME/PASSWORD is not set the docker action will fail. It will now not push to dockerhub.

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the CHANGELOG.md.
  • I have signed the CLA
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@robkooper robkooper requested a review from MBcode July 28, 2022 23:23
@robkooper robkooper force-pushed the fix-fork-docer-build branch from 71cc912 to 8304d4f Compare July 28, 2022 23:28
@lmarini lmarini merged commit 7fe6fa0 into develop Jul 29, 2022
@lmarini lmarini deleted the fix-fork-docer-build branch July 29, 2022 16:16
@robkooper robkooper added this to the 1.21.0 milestone Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants