Skip to content

New enhancement to delete a section #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
robkooper merged 3 commits into from
Dec 14, 2022
Merged

New enhancement to delete a section #385

robkooper merged 3 commits into from
Dec 14, 2022

Conversation

@ddey2
Copy link
Member

@ddey2 ddey2 commented Oct 3, 2022 •
edited
Loading

Description

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the CHANGELOG.md.
  • I have signed the CLA
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@robkooper robkooper linked an issue Oct 5, 2022 that may be closed by this pull request
No way to delete "Sections" from a file page. #347
Closed
tcnichol
tcnichol approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@tcnichol tcnichol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and this one works. Marking approved.

@robkooper robkooper merged commit f286139 into develop Dec 14, 2022
@robkooper robkooper deleted the ddey2/347 branch December 14, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tcnichol tcnichol tcnichol approved these changes

@robkooper robkooper Awaiting requested review from robkooper

@lmarini lmarini Awaiting requested review from lmarini

@longshuicy longshuicy Awaiting requested review from longshuicy

@max-zilla max-zilla Awaiting requested review from max-zilla

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

No way to delete "Sections" from a file page.

4 participants

@ddey2 @tcnichol @robkooper