Skip to content

ddey2/375 #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lmarini merged 5 commits into from
Sep 11, 2023
Merged

ddey2/375 #388

lmarini merged 5 commits into from
Sep 11, 2023

Conversation

@ddey2
Copy link
Member

@ddey2 ddey2 commented Oct 11, 2022 •
edited
Loading

Description

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the CHANGELOG.md.
  • I have signed the CLA
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ddey2 ddey2 linked an issue Oct 11, 2022 that may be closed by this pull request
default role when requesting access to space is admin #375
Closed
@lmarini lmarini merged commit a515dac into develop Sep 11, 2023
@lmarini lmarini deleted the ddey2/375 branch September 11, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmarini lmarini lmarini approved these changes

@longshuicy longshuicy Awaiting requested review from longshuicy

@max-zilla max-zilla Awaiting requested review from max-zilla

@robkooper robkooper Awaiting requested review from robkooper

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

default role when requesting access to space is admin

4 participants

@ddey2 @lmarini @robkooper