Skip to content

Conversation

@ddey2
Copy link
Member

@ddey2 ddey2 commented Oct 31, 2022

Description

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the CHANGELOG.md.
  • I have signed the CLA
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ddey2 ddey2 linked an issue Oct 31, 2022 that may be closed by this pull request
@tcnichol
Copy link
Contributor

I pushed a small change. I was getting some errors but they were small fixes.

I have tried adding files and deleting them, but it doesn't seem my dataset is showing the lastUpdated time changing. Will delete this db and start over and try again.

@ddey2
Copy link
Member Author

ddey2 commented Oct 31, 2022

@tcnichol Thanks, I am looking into this.

…is used when files are uploaded through the web interface. now the dataset time should be updated.
@tcnichol
Copy link
Contributor

tcnichol commented Nov 3, 2022

I made one commit - in datasets.submit i added the same update of the time you had elsewhere. I think that catches it when files are uploaded through the web interface and not the API and will now update the last modified time.

@ddey2 ddey2 marked this pull request as draft November 4, 2022 16:36
@ddey2 ddey2 requested a review from robkooper November 7, 2022 17:07
@ddey2 ddey2 marked this pull request as ready for review November 7, 2022 19:22
Copy link
Contributor

@tcnichol tcnichol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense being in the service. Tested and updates with both API routes and the GUI.

Marking approved.

@ddey2
Copy link
Member Author

ddey2 commented Nov 16, 2022

Adding last modified date to UI

Screen Shot 2022-11-16 at 2 56 31 PM

@robkooper robkooper merged commit 32da80b into develop Dec 5, 2022
@robkooper robkooper deleted the 386-datasetlastmodifieddate-is-not-updated branch December 5, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dataset.lastModifiedDate is not updated

4 participants