Skip to content

311 double click on create dataset creates 2 datasets #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
robkooper merged 2 commits into from
Dec 5, 2022
Merged

311 double click on create dataset creates 2 datasets #397

robkooper merged 2 commits into from
Dec 5, 2022

Conversation

@ddey2
Copy link
Member

@ddey2 ddey2 commented Nov 7, 2022 •
edited
Loading

Description

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the CHANGELOG.md.
  • I have signed the CLA
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ddey2 ddey2 linked an issue Nov 7, 2022 that may be closed by this pull request
double click on create dataset creates 2 datasets #311
Closed
tcnichol
tcnichol approved these changes Nov 19, 2022
View reviewed changes
Copy link
Contributor

@tcnichol tcnichol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to replicate the original bug locally and tested, and this prevents duplicates from being created. Marking this one approved.

@robkooper robkooper merged commit 9192d5c into develop Dec 5, 2022
@robkooper robkooper deleted the 311-double-click-on-create-dataset-creates-2-datasets branch December 5, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robkooper robkooper robkooper approved these changes

@tcnichol tcnichol tcnichol approved these changes

@lmarini lmarini Awaiting requested review from lmarini

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

double click on create dataset creates 2 datasets

4 participants

@ddey2 @robkooper @tcnichol