Skip to content

Conversation

@LDeakin
Copy link
Contributor

@LDeakin LDeakin commented Apr 26, 2023

Description

  • Added a getSections endpoint to get the section IDs of a file
  • Fix some missing section routes in javascriptRoutes
  • Add area and description to Sections.get()

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the CHANGELOG.md.
  • I have signed the CLA
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Apr 26, 2023

CLA assistant check
All committers have signed the CLA.

@lmarini lmarini self-requested a review April 26, 2023 15:01
@lmarini
Copy link
Member

lmarini commented Sep 11, 2023

Hi @LDeakin, thank you for your contribution! Is it ok if we add you to CONTRIBUTORS.md? Is this you? https://www.linkedin.com/in/lachlandeakin/?originalSubdomain=au

I image you use this code in a previewer. Is the code for the previewer available somewhere? Would you like to contribute it to this repository as well?

conf/routes Outdated
POST /api/files/:id/remove @api.Files.removeFile(id: UUID)
POST /api/files/bulkRemove @api.Files.bulkDeleteFiles()
GET /api/files/:id/metadata @api.Files.get(id: UUID)
GET /api/files/:id/getSections @api.Files.getSections(id: UUID)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change the API route to GET /api/files/:id/sections to be consistent and to follow REST rules? Thank you.

@LDeakin
Copy link
Contributor Author

LDeakin commented Sep 12, 2023

Thanks @lmarini, I've renamed getSections to sections.

Hi @LDeakin, thank you for your contribution! Is it ok if we add you to CONTRIBUTORS.md? Is this you? https://www.linkedin.com/in/lachlandeakin/?originalSubdomain=au

That's me. Yes, happy for you to add me to CONTRIBUTORS.md.

I image you use this code in a previewer. Is the code for the previewer available somewhere? Would you like to contribute it to this repository as well?

I could contribute it, but it still needs some work. It is a dataset previewer that overlays images, allows panning/zooming, and annotation with section boxes. Is this of interest?
image

@lmarini
Copy link
Member

lmarini commented Sep 12, 2023

I could contribute it, but it still needs some work. It is a dataset previewer that overlays images, allows panning/zooming, and annotation with section boxes. Is this of interest? image

That looks great @LDeakin! We would love to add it to the default previewers when it's ready. Please let us know if we can help. Thank you.

@lmarini lmarini merged commit 15bd2e7 into clowder-framework:develop Sep 12, 2023
@lmarini lmarini mentioned this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants