Skip to content

fix typo in roles endpoint; disable sharing with myself #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lmarini merged 1 commit into from
Apr 12, 2024
Merged

fix typo in roles endpoint; disable sharing with myself #1002

lmarini merged 1 commit into from
Apr 12, 2024

Conversation

@longshuicy
Copy link
Member

@longshuicy longshuicy commented Apr 12, 2024

  • Fixed a typo on the "role" endpoint url.. there was a trailing "}"
  • Filter out the current user's email in the share options to make sure it can't be shared with the current user.
image

@longshuicy longshuicy linked an issue Apr 12, 2024 that may be closed by this pull request
Sharing with yourself shouldn't be allowed #997
Closed
@longshuicy longshuicy requested review from ddey2 and tcnichol April 12, 2024 19:38
@lmarini lmarini merged commit 4777375 into main Apr 12, 2024
@lmarini lmarini deleted the 997-sharing-with-yourself branch April 12, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmarini lmarini lmarini approved these changes

@max-zilla max-zilla Awaiting requested review from max-zilla max-zilla is a code owner

@ddey2 ddey2 Awaiting requested review from ddey2

@tcnichol tcnichol Awaiting requested review from tcnichol

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sharing with yourself shouldn't be allowed

3 participants

@longshuicy @lmarini