Skip to content

Search needs to be case insensitive #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lmarini merged 1 commit into from
May 14, 2024
Merged

Search needs to be case insensitive #1049

lmarini merged 1 commit into from
May 14, 2024

Conversation

@longshuicy
Copy link
Member

@longshuicy longshuicy commented May 13, 2024

  1. Regex search case insensitive
  2. Frontend displaying use Link component instead of button; Button will end up capitalizing the text as well as add hover effect

@longshuicy longshuicy requested a review from max-zilla as a code owner May 13, 2024 22:06
@longshuicy longshuicy linked an issue May 13, 2024 that may be closed by this pull request
Search should be case insensitive #1043
Closed
@lmarini lmarini merged commit c113f9b into main May 14, 2024
@lmarini lmarini deleted the 1043-search-should-be-case-insensitive branch May 14, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmarini lmarini lmarini approved these changes

@max-zilla max-zilla Awaiting requested review from max-zilla max-zilla is a code owner

@Vismayak Vismayak Awaiting requested review from Vismayak

@ddey2 ddey2 Awaiting requested review from ddey2

@tcnichol tcnichol Awaiting requested review from tcnichol

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Search should be case insensitive

3 participants

@longshuicy @lmarini