-
Notifications
You must be signed in to change notification settings - Fork 6
1061 filesystem UI component #1064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
longshuicy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some example how do I trigger this widget? Do I need a register a special extractor with specific fields? Thanks!
|
@longshuicy sorry for the confusion, I have updated the testing instructions, let me know if the updated instructions are better! |
longshuicy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the write-ups on how to test.
Very cool it is able to pick up the file id and send it to the extract!
I have just a few comments. Let me know if it's not very straightforward to address; then maybe you can create another issue in that case.
ddey2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks very nice. I agree with @longshuicy I think we should show diff icons for datasets and folders to avoid confusion. Rest looks all good.
longshuicy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well.
ddey2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dataset and folder icons look consistent with what we have
To test:
Run an extractor, I used wordcount , locally as in to do the necessary modifications:
extractor-info.jsonfile, in theschemafield ofparameters, if using wordcount, you will have to add it here