Skip to content

Conversation

@Vismayak
Copy link
Contributor

@Vismayak Vismayak commented May 30, 2024

To test:
Run an extractor, I used wordcount , locally as in to do the necessary modifications:

  1. Add another parameter in extractor-info.json file, in the schema field of parameters, if using wordcount, you will have to add it here
    "DATASET_FILE_ID":{
            "type":"string",
            "title":"Dataset file ID",
            "description":"The Clowder file id of the dataset file to be used for inference",
            "format": "clowderFile"
       },
  1. When you open the ford for the wordcount extractor after running it locally, you will see the widget

image

image

  1. After you choose a file and click submit, use the network tab from inspect tools, you will see that the corresponding DATASET_FILE_ID has been passsed in the requests
    image

@Vismayak Vismayak requested a review from longshuicy as a code owner May 30, 2024 16:26
@Vismayak Vismayak linked an issue May 30, 2024 that may be closed by this pull request
Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some example how do I trigger this widget? Do I need a register a special extractor with specific fields? Thanks!

@Vismayak
Copy link
Contributor Author

@longshuicy sorry for the confusion, I have updated the testing instructions, let me know if the updated instructions are better!

@Vismayak Vismayak requested review from ddey2, lmarini and tcnichol June 6, 2024 14:04
Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the write-ups on how to test.
Very cool it is able to pick up the file id and send it to the extract!
I have just a few comments. Let me know if it's not very straightforward to address; then maybe you can create another issue in that case.

Copy link
Member

@ddey2 ddey2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very nice. I agree with @longshuicy I think we should show diff icons for datasets and folders to avoid confusion. Rest looks all good.

@Vismayak Vismayak requested review from ddey2 and longshuicy June 7, 2024 20:59
Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well.

Copy link
Member

@ddey2 ddey2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dataset and folder icons look consistent with what we have

@longshuicy longshuicy merged commit 2c2d76f into main Jun 10, 2024
@longshuicy longshuicy deleted the 1061-filesystem-ui-component branch June 10, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filesystem UI component

4 participants