1069 show message when no metadata is present#1112
Merged
longshuicy merged 7 commits intomainfrom Jun 28, 2024
Merged
Conversation
longshuicy
requested changes
Jun 28, 2024
Member
longshuicy
left a comment
longshuicy
left a comment
There was a problem hiding this comment.
Coud you resolve merge conflict?
ddey2
requested changes
Jun 28, 2024
Member
ddey2
left a comment
ddey2
left a comment
There was a problem hiding this comment.
It always says 'no user metadata provided for dataset', even for files.
…n-no-metadata-is-present # Conflicts: # frontend/src/components/metadata/DisplayMetadata.tsx
using 'resource' instead of 'dataset' in message
Contributor
Author
I changed 'dataset' to 'resource' so that both messages just say 'resource'. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added some messages here if there is no extractor or user metadata, for datasets or files.
@lmarini I used the text you had supplied in the issue for the user metadata, and came up with something else for machine metadata. I think the text in those spaces can be better, but I wanted this to be a draft now so others can weigh in on the messages.