Skip to content

Conversation

@ddey2
Copy link
Member

@ddey2 ddey2 commented Jun 20, 2024

Current file entry should look like this:
Screenshot 2024-06-20 at 11 48 54 AM

@ddey2 ddey2 requested a review from longshuicy as a code owner June 20, 2024 16:53
@ddey2 ddey2 linked an issue Jun 20, 2024 that may be closed by this pull request
@ddey2 ddey2 requested review from Vismayak, lmarini and tcnichol June 20, 2024 16:53
Copy link
Contributor

@tcnichol tcnichol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine I'm marking approved.

Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you match folder to match the column number
image

@ddey2 ddey2 requested a review from longshuicy June 24, 2024 15:21
@ddey2
Copy link
Member Author

ddey2 commented Jun 24, 2024

Could you match folder to match the column number image

done. Good catch, thanks!

Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected now.

@longshuicy longshuicy merged commit b391ea1 into main Jun 24, 2024
@longshuicy longshuicy deleted the 1021-history-the-version-chip-1 branch June 24, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

History - the version chip

4 participants