Use the update flag when updating fields of existing Elasticsearch entry #1136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longshuicy
changed the title
longshuicy
commented
Jul 2, 2024
| return await patch_metadata(md, content, es) | ||
| patched_metadata = await patch_metadata(md, content, es) | ||
| await index_dataset(es, DatasetOut(**dataset.dict()), update=True) | ||
| return patched_metadata |
Member
Author
There was a problem hiding this comment.
There was a bug here. The metadata is updated after indexing hence the updated metadata never reflected
ddey2
approved these changes
Jul 8, 2024
Member
ddey2
left a comment
ddey2
left a comment
There was a problem hiding this comment.
looks good. Good catch for the bug!
lmarini
deleted the
1122-index-file-update-flag-need-to-be-specifically-set-to-true-in-the-put-endpoint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the correct "update" flag to places where elasticsearch entry already existed.
Fixed a bug related to "update dataset metadata".
Fixed a few parameters to its correct data type e.g. DatasetOut, FileOut