error message when sharing dataset with user

[tcnichol]

Previously when you shared a dataset with a user, it showed an error message but the user was added.

I have fixed this so now you get the success message.

[ddey2]

This looks okay.

I was wondering why it was previously needed to explicitly check for user role and verify if the user was added on frontend. Looks like @tcnichol you wrote this code. Do you remember?

[tcnichol]

This looks okay.

I was wondering why it was previously needed to explicitly check for user role and verify if the user was added on frontend. Looks like @tcnichol you wrote this code. Do you remember?

I think if I didn't do this the page did not show the user that was added correctly.

[tcnichol]

I looked at the db here.

Looks like it is working as intended. A user does not have multiple roles on any dataset, their id is removed from the old Authorization object. That object is not deleted because other user_ids might be in that object. If it is empty, then if you add a user with that role, that existing authorization is updated with the user_id added.