-
Notifications
You must be signed in to change notification settings - Fork 6
Fix refresh token issue when using password flow #1205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix refresh token issue when using password flow #1205
Conversation
longshuicy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and tested.
One thing I noticed is the "deprecated" not seems to work? I can still POST to the /api/v2/login endpoint with no issue. And i didn't see any notification either.
Could you look into that? if it's not straightforward, maybe we can just delete this endpoint. But we might be careful, a quick search I found there are some scripts (in the scripts folder) still uses this endpoint.
|
After we discussed, could you try below: @GalMunGral
@max-zilla if I've missed anything, please chime in. |
Will do! |
|
@longshuicy i will take a look at this also but it's ready for another look, thanks. |
longshuicy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and functionality works. Approve.
POST /loginandPOST /auth/loginhave the exact same logic. @longshuicy suggested deprecating thePOST /loginendpoint.GET /auth) so that access tokens obtained through the password flow (POST /auth/login) can also be refreshed byGET /auth/refresh_token.