-
Notifications
You must be signed in to change notification settings - Fork 6
12 create dataset from zip #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creates dataset with folders and subfolders not sure if this is a good way of handling unzipping files
Closed
Contributor
Author
|
The back end endpoint works, but there are 2 things that are still needed.
|
Contributor
|
I updated this a little:
Tested round-robin upload zip -> download zip and it seems to work as intended. Gonna test a couple more edge cases before merge |
max-zilla
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backend endpoint currently works. You can upload a zip and it will create a dataset with folders and subfolders.
Right now the zip file is unzipped in the working directory. That should probably be changed but not sure what would be best practice.
Not connected to the front end.