Skip to content

443 frontend need to display more verbose backend error #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
longshuicy merged 5 commits into from
Apr 27, 2023
Merged

443 frontend need to display more verbose backend error #458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7d230d3
Updated frontend error message to be more verbose
arunapa Apr 20, 2023
f7c0e79
Fixed report button issue
arunapa Apr 20, 2023
0ab4524
Fixing issue with error message
arunapa Apr 27, 2023
e732474
Revert "Updated frontend error message to be more verbose"
arunapa Apr 27, 2023
70a0ca9
Fixing issue with error message
arunapa Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions frontend/src/actions/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export function handleErrors(reason, originalFunc){
return (dispatch) => {
dispatch({
type: NOT_AUTHORIZED,
reason: "Forbidden",
reason: reason.body.detail,
stack: reason.stack ? reason.stack : "",
receivedAt: Date.now()
});
Expand All @@ -73,7 +73,7 @@ export function handleErrors(reason, originalFunc){
return (dispatch) => {
dispatch({
type: NOT_FOUND,
reason: "Not Found",
reason: reason.body.detail,
stack: reason.stack ? reason.stack : "",
receivedAt: Date.now()
});
Expand All @@ -82,7 +82,7 @@ export function handleErrors(reason, originalFunc){
return (dispatch) => {
dispatch({
type: FAILED,
reason: reason.message !== undefined? reason.message : "Backend Failure. Couldn't fetch!",
reason: reason.body.detail !== undefined? reason.body.detail : "Backend Failure. Couldn't fetch!",
stack: reason.stack ? reason.stack : "",
receivedAt: Date.now()
});
Expand Down
6 changes: 4 additions & 2 deletions frontend/src/components/Explore.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,10 @@ export const Explore = (): JSX.Element => {
setErrorOpen(false);
}
const handleErrorReport = () => {
window.open(`${config.GHIssueBaseURL}+${reason}&body=${encodeURIComponent(stack)}`);
}
window.open(
`${config.GHIssueBaseURL}+${encodeURIComponent(reason)}&body=${encodeURIComponent(stack)}`
);
};

// fetch thumbnails from each individual dataset/id calls
useEffect(() => {
Expand Down
6 changes: 4 additions & 2 deletions frontend/src/components/datasets/CreateDataset.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,10 @@ export const CreateDataset = (): JSX.Element => {
setErrorOpen(false);
}
const handleErrorReport = () => {
window.open(`${config.GHIssueBaseURL}+${reason}&body=${encodeURIComponent(stack)}`);
}
window.open(
`${config.GHIssueBaseURL}+${encodeURIComponent(reason)}&body=${encodeURIComponent(stack)}`
);
};

// step 1
const onDatasetSave = (formData:any) =>{
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/components/datasets/Dataset.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,9 @@ export const Dataset = (): JSX.Element => {
dismissError();
setErrorOpen(false);
};
const handleErrorReport = (reason: string) => {
const handleErrorReport = () => {
window.open(
`${config.GHIssueBaseURL}+${reason}&body=${encodeURIComponent(stack)}`
`${config.GHIssueBaseURL}+${encodeURIComponent(reason)}&body=${encodeURIComponent(stack)}`
);
};

Expand Down
4 changes: 2 additions & 2 deletions frontend/src/components/files/File.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,9 @@ export const File = (): JSX.Element => {
dismissError();
setErrorOpen(false);
};
const handleErrorReport = (reason: string) => {
const handleErrorReport = () => {
window.open(
`${config.GHIssueBaseURL}+${reason}&body=${encodeURIComponent(stack)}`
`${config.GHIssueBaseURL}+${encodeURIComponent(reason)}&body=${encodeURIComponent(stack)}`
);
};

Expand Down
6 changes: 4 additions & 2 deletions frontend/src/components/listeners/ExtractionHistory.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,10 @@ export const ExtractionHistory = (): JSX.Element => {
setErrorOpen(false);
}
const handleErrorReport = () => {
window.open(`${config.GHIssueBaseURL}+${reason}&body=${encodeURIComponent(stack)}`);
}
window.open(
`${config.GHIssueBaseURL}+${encodeURIComponent(reason)}&body=${encodeURIComponent(stack)}`
);
};

return (
<Layout>
Expand Down