Skip to content

Conversation

@longshuicy
Copy link
Member

image

Support basic "line", "scatter" and "bar chart"

@longshuicy longshuicy linked an issue Sep 18, 2023 that may be closed by this pull request
@max-zilla
Copy link
Contributor

I had to manually npm install csvtojson as regular npm install wasn't finding it, not sure if there is a proper method to isntall since i see you list that in the manifest.

Once I installed that, worked perfectly.

@longshuicy
Copy link
Member Author

I had to manually npm install csvtojson as regular npm install wasn't finding it, not sure if there is a proper method to isntall since i see you list that in the manifest.

Once I installed that, worked perfectly.

Ah i forgot to include that in package-json. Just did and pushed. Thanks!

@longshuicy longshuicy changed the title WIP 733 vega visualization 733 vega visualization Sep 19, 2023
Copy link
Contributor

@max-zilla max-zilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked well with 3 (well-structured) CSV files.

Copy link
Member

@ddey2 ddey2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so cool. Works well decent size csv files with proper headers. Also, you need to do npm install.

@max-zilla max-zilla merged commit a03a94f into main Sep 20, 2023
@max-zilla max-zilla deleted the 733-vega-visualization branch September 20, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Vega visualization

4 participants