Skip to content

Conversation

@longshuicy
Copy link
Member

Backend:

  • Use aggregated query to calculate "alive" at the whole collection level; then apply different filters

Frontend

  • Add a switch to toggle on/off view only alive extractors
image

@longshuicy longshuicy requested a review from max-zilla as a code owner January 9, 2024 22:33
@longshuicy longshuicy linked an issue Jan 9, 2024 that may be closed by this pull request
Copy link
Member

@ddey2 ddey2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks okay but I am not able to get it working.
@longshuicy I am testing the code by setting the heartbeat interval to 20 secs and stopping the extractor. I am still finding the extractor to be alive even after several minutes. Is there something I am missing?
Screenshot 2024-01-16 at 2 55 08 PM
Screenshot 2024-01-16 at 2 54 53 PM
Screenshot 2024-01-16 at 2 54 58 PM

@longshuicy
Copy link
Member Author

The code looks okay but I am not able to get it working. @longshuicy I am testing the code by setting the heartbeat interval to 20 secs and stopping the extractor. I am still finding the extractor to be alive even after several minutes. Is there something I am missing? Screenshot 2024-01-16 at 2 55 08 PM Screenshot 2024-01-16 at 2 54 53 PM Screenshot 2024-01-16 at 2 54 58 PM

This is the "default" fallback. Maybe just don't change anything and wait for 5 minutes see if it died. If not I can revisit and see if there is a bug in my code. Thank you!

@tcnichol
Copy link
Contributor

I noticed the same thing as @ddey2 but with 5 minutes. If I left the tab and went back the dot was red though.

@ddey2
Copy link
Member

ddey2 commented Jan 17, 2024

I think I am having issues running extractors. Clowder isn't getting any messages from the extractor. That's the reason why I am probably not seeing the red dots even after 5 mins.

@tcnichol If you've tested the code, feel free to approve and merge it.

@lmarini
Copy link
Member

lmarini commented Jan 17, 2024

@longshuicy @ddey2 @tcnichol It worked for me. I just had to refresh the page to see the red dot.

@lmarini lmarini requested a review from ddey2 January 18, 2024 20:15
@lmarini lmarini merged commit 6cf0037 into main Jan 18, 2024
@lmarini lmarini deleted the 844-toggle-on-and-off-of-the-extractor-livelihood branch January 18, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Toggle on and off of the extractor livelihood

5 participants