style of the sharing table; link to the group/{group_id} page #967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
longshuicy
commented
Mar 12, 2024
longshuicy
commented
- Clean up the sharing sub table
- Link group to the /groups/{id}
Contributor
|
This looks good. I just see an error for codegen, but aside from that this is good to go. |
tcnichol
approved these changes
Mar 22, 2024
Contributor
tcnichol
left a comment
tcnichol
left a comment
There was a problem hiding this comment.
Since codegen is now fixed I will mark this approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.