Skip to content

Conversation

@ddey2
Copy link
Member

@ddey2 ddey2 commented Mar 28, 2024

Steps to test:

  1. create a metadata definition
  2. Click on it
  3. Click on edit button on top right
  4. Play around with various fields of metadata definition and
Screenshot 2024-04-11 at 10 02 41 PM Screenshot 2024-04-11 at 10 02 47 PM try to update it.

@ddey2 ddey2 linked an issue Mar 28, 2024 that may be closed by this pull request
@ddey2 ddey2 requested review from lmarini, longshuicy and tcnichol and removed request for longshuicy and max-zilla March 28, 2024 02:58
@ddey2 ddey2 marked this pull request as draft March 28, 2024 02:58
@ddey2 ddey2 changed the title initial draft for updating metadata definition Implement edit metadata definition Apr 12, 2024
@ddey2 ddey2 marked this pull request as ready for review April 12, 2024 03:08
@tcnichol
Copy link
Contributor

tcnichol commented May 2, 2024

Something that I tried.

I created a metadata definition where the input type was a text string.

Then I changed it to a date picker.

When I go to the file with the metadata, and I edit it, I get the new select.

But if I click on the 'add metadata' button instead of editing the existing metadata, I get a blank screen. This happens both before I edit the metadata value (when it's still a string even though the definition is a DateTimePicker) or after.

@tcnichol
Copy link
Contributor

tcnichol commented May 2, 2024

I also noticed that the 'Add Metadata' button is missing on the Dataset page on this branch, but it is present in main. So this branch might just need a merge with main to fix that.

@ddey2
Copy link
Member Author

ddey2 commented May 3, 2024

I also noticed that the 'Add Metadata' button is missing on the Dataset page on this branch, but it is present in main. So this branch might just need a merge with main to fix that.

merged main

@ddey2
Copy link
Member Author

ddey2 commented May 3, 2024

Something that I tried.

I created a metadata definition where the input type was a text string.

Then I changed it to a date picker.

When I go to the file with the metadata, and I edit it, I get the new select.

But if I click on the 'add metadata' button instead of editing the existing metadata, I get a blank screen. This happens both before I edit the metadata value (when it's still a string even though the definition is a DateTimePicker) or after.

looks like "Add metadata" button is not working on main. I created a separate issue #1033

Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Could you remove all the console.log?
  • If the metadata definition is modified, but there are already metadata created using this definition, there might be some inconsistency. We might want to think about what should be the behavior

@ddey2
Copy link
Member Author

ddey2 commented Jun 3, 2024

This Pr needs some more work related to editing metadata defn if already some metadata exists with old defn. It’s listed here in the issue #934.

I will address the comments together. Marking it draft for now.

@ddey2 ddey2 marked this pull request as draft June 3, 2024 16:16
@ddey2 ddey2 marked this pull request as ready for review June 7, 2024 03:23
@ddey2
Copy link
Member Author

ddey2 commented Jun 7, 2024

Right now, I have disabled editing metadata definition if metadata exists adhering to that definition. It will throw exception
Screenshot 2024-06-06 at 10 07 33 PM

@ddey2 ddey2 requested review from Vismayak and longshuicy June 7, 2024 03:24
Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well. Thanks!

@Vismayak
Copy link
Contributor

Vismayak commented Jun 7, 2024

works good, doesnt let me edit as wanted if a metadata already exists 😄

@longshuicy longshuicy merged commit ead8d85 into main Jun 10, 2024
@longshuicy longshuicy deleted the 934-edit-metadata-definitions branch June 10, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit metadata definitions

4 participants