Bugfix/36 dataset extractor fails empty dataset #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I think this one should be good to go. The api route for downloading datasets returns a network error. The pyclowder.datasets.download method fails in chunking (the zip file is 0 bytes) There might be a better fix, but this one should work for now. |
|
|
log exceptin when downloading dataset
robkooper
approved these changes
Feb 22, 2022
robkooper
deleted the
bugfix/36-dataset-extractor-fails-empty-dataset
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feels more like a hack than an actual fix, so I could use some feedback.
Previously a dataset extractor would fail if the dataset had no files because it would try to download a zip of the dataset. That part of the code is in an ELSE block that happens if the dataset has no files, so it didn't really make sense to me, so I left some of the code but return empty lists if there are no files.