dedicated pathword instance for gridworld#4
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d5f1c32869
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!pathworldInstance || pathworldInstance.status !== "running") { | ||
| this.logger.warn(`[gridworld] request_train_path: pathworld instance ${pathworldId} not running (status=${pathworldInstance?.status ?? "not found"})`); | ||
| return; |
There was a problem hiding this comment.
When the pathworld instance is not running, this handler returns without sending any response back to the source tile instance. In train_path_manager.request_train_path, the requesting train is switched to manual mode and is only restored in apply_train_path_result, so dropped requests during pathworld outages/restarts can leave trains permanently stuck in manual mode until a human resets them.
Useful? React with 👍 / 👎.
1 participant
No description provided.