Workaround for #261 #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests were commented out because they break test isolation. The fix of taurus-org#365 may have solved the root cause of this, so reenable them.
In some conditions (e.g. while testing in travis) a race condition makes some test involving DSs to fail (see taurus-org#261). The ultimate cause is not yet clear but it seems related to reading ocurring before the DS is ready. Force sleep after DS starting as workaround and remove sleeps from workaround for taurus-org#334 which seem redundant now.
In the past we observed random failures for this test: ~~~~~~~~~~~~~~~~~~~~~~~ FAIL: test_bgRole (...) expected: (0, 255, 0) got: (239, 240, 241) # <-- these values change (unitialized garbage?) ~~~~~~~~~~~~~~~~~~~~~~~ The fix of taurus-org#365 seems to fix that, so reenable the test.
The test-timer test is not deterministic. It may fail occasionally (e.g. if the machine is overloaded) cause testsuite failures that interfere with CI. Exclude this test in travis.
This reverts commit 1fce9c5.
Implement a processEvents method that loops several times over QApplication.processEvents and use it in the tests to try to avoid random tests failures in taurus.qt tests.
AttributeTestCase.write_read_attr helper uses attr.write(with_read=True) for reading the value. This may lead to reading None in some cases (e.g. attr.isUsingEvents() returns True) and cause the test to fail. Do separated write and read (without cache) instead.
|
The repeated tests failed 2 times of ~120. In both cases, the error was from the same test (but a different property being tested): In e58d856 and , in 599dec4 Even if it is still not perfect, the situation seems to have improved a lot.At least enough for applying the fixes in the official repo... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for testing the fixing of the testsuite