Skip to content

Use C++11#59

Merged
nshmyrev merged 1 commit intocmusphinx:masterfrom
calebegg:patch-1
Mar 12, 2019
Merged

Use C++11#59
nshmyrev merged 1 commit intocmusphinx:masterfrom
calebegg:patch-1

Conversation

@calebegg
Copy link
Copy Markdown

@calebegg calebegg commented Mar 12, 2019

Node/V8 now use some C++11 features, like constexpr. Without this line, CMake can't compile correctly. I get:

/Users/calebegg/.cmake-js/node-x64/v10.8.0/include/node/v8.h:4587:10: error: 
      unknown type name 'constexpr'
  static constexpr size_t kMaxLength =
         ^

@calebegg
Use C++11
0f0f7c7 
Node/V8 now use some C++11 features, like `constexpr`. Without this line, CMake can't compile correctly. I get:

```
/Users/calebegg/.cmake-js/node-x64/v10.8.0/include/node/v8.h:4587:10: error: 
      unknown type name 'constexpr'
  static constexpr size_t kMaxLength =
         ^
```
@nshmyrev nshmyrev merged commit 1f54c72 into cmusphinx:master Mar 12, 2019
@nshmyrev
Copy link
Copy Markdown

nshmyrev commented Mar 12, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@calebegg @nshmyrev