annotations: add wip for messages and fields#11
Merged
mattklein123 merged 5 commits intocncf:mainfrom Sep 22, 2021
mattklein123:add_message_field_status
Merged
annotations: add wip for messages and fields#11mattklein123 merged 5 commits intocncf:mainfrom mattklein123:add_message_field_status
mattklein123 merged 5 commits intocncf:mainfrom
mattklein123:add_message_field_status
Conversation
Part of envoyproxy/envoy#17920 Signed-off-by: Matt Klein <mklein@lyft.com>
markdroth
reviewed
Sep 7, 2021
Contributor
markdroth
left a comment
markdroth
left a comment
There was a problem hiding this comment.
One quick change suggestion, but otherwise looks good.
htuch
reviewed
Sep 10, 2021
Contributor
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
LGTM modulo the s/udpa/xds/.
Contributor
Author
|
@htuch @markdroth this should be ready to go, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of envoyproxy/envoy#17920
Signed-off-by: Matt Klein mklein@lyft.com