Skip to content

pgv_plugin_go : Use protoc_gen_validate instead of xds#92

Merged
adisuissa merged 1 commit intocncf:mainfrom
mmorel-35:pgv_plugin_go
Mar 25, 2024
Merged

pgv_plugin_go : Use protoc_gen_validate instead of xds#92
adisuissa merged 1 commit intocncf:mainfrom
mmorel-35:pgv_plugin_go

Conversation

@mmorel-35
Copy link
Copy Markdown
Contributor

com_envoyproxy_protoc_gen_validate provides the go_proto_compiler with this exact same configuration

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Copy link
Copy Markdown
Contributor Author

mmorel-35 commented Mar 25, 2024

@adisuissa , WDYT ?
This is already applied in envoy, see : envoyproxy/envoy#33061

Copy link
Copy Markdown

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@adisuissa adisuissa merged commit 0335649 into cncf:main Mar 25, 2024
@mmorel-35 mmorel-35 deleted the pgv_plugin_go branch March 25, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants