app.js: Exclude mentors on completed projects

[corona10]

Closes #491

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

• I read the commit guidelines and I've followed
  them.
• I ran coala over my code locally. (All commits have to pass
  individually. It is not sufficient to have "fixup commits" on your PR,
  our bot will still report the issues for the previous commit.) You will
  likely receive a lot of bot comments and build failures if coala does not
  pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

• pick up any PR at https://coala.io/review
• review it (check https://coala.io/reviewing for more info)
• if you are sure that it needs work, use cobot mark wip <URL> to get it out
  of the review queue.

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

[gitmate-bot]

Line contains following spacing inconsistencies:

• Tabs used instead of spaces.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpcz9e_4wy/resources/js/app.js
+++ b/tmp/tmpcz9e_4wy/resources/js/app.js
@@ -382,7 +382,7 @@
                     .then(function (res) {
                         $scope.projects = res.data
                         angular.forEach($scope.projects, function(value, key){
-			    if ("status" in value && value.status == "completed") {
+                if ("status" in value && value.status == "completed") {
 				    return;
 			    }
                             angular.forEach(value.mentors, function(value, key){

[gitmate-bot]

Line contains following spacing inconsistencies:

• Tabs used instead of spaces.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpcz9e_4wy/resources/js/app.js
+++ b/tmp/tmpcz9e_4wy/resources/js/app.js
@@ -383,7 +383,7 @@
                         $scope.projects = res.data
                         angular.forEach($scope.projects, function(value, key){
 			    if ("status" in value && value.status == "completed") {
-				    return;
+                    return;
 			    }
                             angular.forEach(value.mentors, function(value, key){
                                 self.mentorsList[value] =  {

[gitmate-bot]

Line contains following spacing inconsistencies:

• Tabs used instead of spaces.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpcz9e_4wy/resources/js/app.js
+++ b/tmp/tmpcz9e_4wy/resources/js/app.js
@@ -384,7 +384,7 @@
                         angular.forEach($scope.projects, function(value, key){
 			    if ("status" in value && value.status == "completed") {
 				    return;
-			    }
+                }
                             angular.forEach(value.mentors, function(value, key){
                                 self.mentorsList[value] =  {
                                     "github_handle" : value,

[corona10]

@jayvdb PTAL

[saksham189]

:)

[li-boxuan]

Hi, seems you are working on an unassigned issue. Also, I think you should use 'closes' instead of 'fix' in your commit message. :)

[corona10]

@li-boxuan
AFAIK, I can not assign my self on that issue through corobo.

[jayvdb]

Closes <url> needs to be updated to be like http://coala.io/commit ;

[corona10]

@jayvdb Updated!

[jayvdb]

ack d9d6111

[jayvdb]

@gitmate-bot ff

[gitmate-bot]

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

[gitmate-bot]

Automated fastforward with GitMate.io was successful! 🎉