Skip to content

release-24.1: dev: refactor prompts for autofix permission#128222

Merged
rickystewart merged 2 commits intorelease-24.1from
blathers/backport-release-24.1-128211
Aug 2, 2024
Merged

release-24.1: dev: refactor prompts for autofix permission#128222
rickystewart merged 2 commits intorelease-24.1from
blathers/backport-release-24.1-128211

Conversation

@blathers-crl
Copy link
Copy Markdown

@blathers-crl blathers-crl Bot commented Aug 2, 2024

Backport 2/2 commits from #128211 on behalf of @rickystewart.

/cc @cockroachdb/release


This code is duplicated in many places, so this refactor saves us some
LOC.

Epic: none
Release note: None
Release justification: Build-only code changes


Release justification:

This was apparently broken with the Bazel 7 upgrade and
bazelbuild/bazel#22001 specifically. If `--test_tmpdir` is set to
some directory under `/tmp`, we need to add `/tmp` as a mount pair as
well. This cannot be done in remote mode so `doctor` needs to be aware
of this.

Closes: #128204
Epic: None
Release note: None
Release justification: Build-only code changes
This code is duplicated in many places, so this refactor saves us some
LOC.

Epic: none
Release note: None
Release justification: Build-only code changes
@blathers-crl blathers-crl Bot requested a review from a team as a code owner August 2, 2024 21:05
@blathers-crl blathers-crl Bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Aug 2, 2024
@blathers-crl blathers-crl Bot requested a review from rail August 2, 2024 21:05
@blathers-crl
Copy link
Copy Markdown
Author

blathers-crl Bot commented Aug 2, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl Bot added the backport Label PR's that are backports to older release branches label Aug 2, 2024
@blathers-crl
Copy link
Copy Markdown
Author

blathers-crl Bot commented Aug 2, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@rickystewart rickystewart merged commit 67fe457 into release-24.1 Aug 2, 2024
@rickystewart rickystewart deleted the blathers/backport-release-24.1-128211 branch August 2, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. v24.1.4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants