release-24.2: dev: in doctor, add --sandbox_add_mount_pair if relevant#128224
Merged
rickystewart merged 1 commit intorelease-24.2from Aug 2, 2024
Merged
release-24.2: dev: in doctor, add --sandbox_add_mount_pair if relevant#128224rickystewart merged 1 commit intorelease-24.2from
doctor, add --sandbox_add_mount_pair if relevant#128224rickystewart merged 1 commit intorelease-24.2from
Conversation
This was apparently broken with the Bazel 7 upgrade and bazelbuild/bazel#22001 specifically. If `--test_tmpdir` is set to some directory under `/tmp`, we need to add `/tmp` as a mount pair as well. This cannot be done in remote mode so `doctor` needs to be aware of this. Closes: #128204 Epic: None Release note: None Release justification: Build-only code changes
bfc2ddd to
c4547c1
Compare
Author
|
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
Author
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
rail
approved these changes
Aug 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #128207 on behalf of @rickystewart.
/cc @cockroachdb/release
This was apparently broken with the Bazel 7 upgrade and bazelbuild/bazel#22001 specifically. If
--test_tmpdiris set to some directory under/tmp, we need to add/tmpas a mount pair as well. This cannot be done in remote mode sodoctorneeds to be aware of this.Closes: #128204
Epic: None
Release note: None
Release justification: Build-only code changes
Release justification: