admission: compute upper bound from target util #158907
Open
+51
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the upper bound computation done in cpuTimeTokenLinearModel to use the smallest target CPU utilization across all the token buckets in cpuTimeTokenGranter. Previously, this computation used a hard-coded target utilization, which was a bug. Release note: None. <what was there before: Previously, ...> <why it needed to change: This was inadequate because ...> <what you did about it: To address this, this patch ...>
Member
|
This change is |
sumeerbhola
approved these changes
Dec 5, 2025
Collaborator
sumeerbhola
left a comment
sumeerbhola
left a comment
There was a problem hiding this comment.
@sumeerbhola reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @joshimhoff and @tbg)
pkg/util/admission/cpu_time_token_filler.go line 65 at r1 (raw file):
const ( // See the extensive comments in fit near isLowCPUUtil for info regarding
nit: ... extensive comments near isLowCPUUtil declaration for info ...
(I couldn't make sense of "in fit")
pkg/util/admission/cpu_time_token_filler.go line 71 at r1 (raw file):
// settings can be set to. < 50% CPU utilization is not a cost-effective choice, // as it leads lots of hardware resources unused, even in case of short spikes. // So we do not support < 50% CPU utilization.
nit: The "So we do ..." is not adding any new information. Consider deleting it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
admission: compute upper bound from target util
This commit updates the upper bound computation done in cpuTimeTokenLinearModel to use the smallest target CPU utilization across all the token buckets in
cpuTimeTokenGranter. Previously, this computation used a hard-coded target utilization, which was a bug.
Release note: None.
Fixes: #158600
This addresses the following comment from an earlier PR: https://reviewable.io/reviews/cockroachdb/cockroach/157029#-OfUmUtz2cStbN9M9tuf