build: don't put .node_modules/bin on the path#18181
Merged
benesch merged 1 commit intocockroachdb:masterfrom Sep 5, 2017
Merged
build: don't put .node_modules/bin on the path#18181benesch merged 1 commit intocockroachdb:masterfrom
benesch merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
knz
approved these changes
Sep 2, 2017
Contributor
knz
left a comment
knz
left a comment
There was a problem hiding this comment.
Thanks, this makes me happy today. 💖
benesch
force-pushed
the
no-node-modules-bin
branch
from
3c776d3 to
805dab0
Compare
Contributor
|
Reviewed 4 of 4 files at r1. Comments from Reviewable |
benesch
force-pushed
the
no-node-modules-bin
branch
from
805dab0 to
8a30993
Compare
Since Yarn 0.25 (yarnpkg/yarn#3310), Yarn transitively symlinks binaries into node_modules/.bin. (Previously, it would only sync top-level binaries--i.e., binaries that we directly depend on.) The new behavior results in adding all sorts of junk to the path--notably, a JavaScript which reimplementation that shadows the system-provided which. Ew. Avoid putting node_modules/.bin on the PATH by using full paths to the binaries within, or using `yarn run` if within pkg/ui.
benesch
force-pushed
the
no-node-modules-bin
branch
from
8a30993 to
52b7ccc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Yarn 0.25 (yarnpkg/yarn#3310), Yarn transitively symlinks binaries
into node_modules/.bin. (Previously, it would only sync top-level
binaries--i.e., binaries that we directly depend on.) The new behavior
results in adding all sorts of junk to the path--notably, a JavaScript
which reimplementation that shadows the system-provided which. Ew.
Avoid putting node_modules/.bin on the PATH by using full paths to the
binaries within, or using
yarn runif within pkg/ui.