fix: remove logging.basicConfig from __init__.py#155
Open
filhocf wants to merge 1 commit into
Open
Conversation
Calling logging.basicConfig() at import time configures the root logger for the entire Python process, which interferes with logging setups in applications that use cocoindex-code as a dependency. Libraries should not configure the root logger — that is the application's responsibility. Closes cocoindex-io#124
Author
|
@gemini-code-assist review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
logging.basicConfig(level=logging.WARNING)call from__init__.py.Problem
Calling
logging.basicConfig()at import time configures the root logger for the entire Python process. This interferes with logging setups in applications that usecocoindex-codeas a dependency — any app that doesimport cocoindex_codegets its root logger silently reconfigured.Fix
Remove the
logging.basicConfig()call. Libraries should not configure the root logger; that is the application's responsibility.The
daemon.pyalready has its ownlogging.basicConfig()call (line 600) which correctly configures logging when the daemon starts, so this removal has no impact on the CLI/daemon behavior.Closes #124